Support cast run quorum private txn #9058
Conversation
* feat: rust error handling * feat: pass through eth_getQuorumPayload errors * chore: replace logs with println macro
rodionlim
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
crates/cast/bin/cmd/run.rs
Outdated
| if let Some(signature) = tx.inner.signature { | ||
| let v = signature.v; |
There was a problem hiding this comment.
not opposed to this, but I'd like to have this ideally as a separate function so we can properly document this and have this isolated.
this should probably also check the chainid?
There was a problem hiding this comment.
Hi @mattsse
We agree on the first point to create a separate function, will update the PR
On the chainId topic:
Quorum explicitly doesn't allow a chainId of 1, it will not run if it is configured this way
https://docs.goquorum.consensys.io/concepts/network-and-chain-id
Are you saying that if chainId is 1, then is_private_quorum_txn should be false here?
There was a problem hiding this comment.
@mattsse, I refactored this out into a separate function, not sure if you want it isolated via a CLI flag as well
|
Personally not a fan as it is highly vendor specific and therefore I would be hesitant to add this; not because of the proposed functionality of implementation but whenever we implement a feature in Foundry we try to be as neutral as possible, avoid having vendor-specific logic and avoid enshrining winners. A good example of how a vendor specific request for Kontrol cheatcodes was turned into generalized functionality available to all and non-specific can be seen here: #4072 |
Signed-off-by: Rodion Lim <[email protected]>
This PR is raised to support debugging Quorum private transactions with
cast run. Context: #9057Motivation
Quorum private transactions are not generating the right traces with
casttooling due to the way that the client masks the actual transaction input data.Solution
Quorum private transactions have a specified format that is unique to the blockchain. The transaction input is a 64 bytes Tessera hash, and the recovery id of a private transaction can only be 37/38. Based on the criteria, we can get the CLI to make an additional RPC call to fetch the actual private transaction input data to replace the tessera hash.